Skip to content

[PM-23722] remove previous change for the account security badge #15739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Jul 22, 2025

🎟️ Tracking

PM-23722

📔 Objective

Remove previously added badge that was thought to be missing. Recent design changes we will not be having a badge for Account Security. The nudge in account security is more educational for the user and no badge is required.

📸 Screenshots

Screenshot 2025-07-22 at 3 56 19 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested review from a team as code owners July 22, 2025 19:58
@Jingo88 Jingo88 requested a review from jaasen-livefront July 22, 2025 19:58
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details41366d15-6034-4a36-a7e4-e13c5b1c86a4

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.57%. Comparing base (319528c) to head (6606446).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15739      +/-   ##
==========================================
- Coverage   37.58%   37.57%   -0.01%     
==========================================
  Files        3320     3320              
  Lines       94806    94804       -2     
  Branches    14343    14343              
==========================================
- Hits        35629    35622       -7     
- Misses      57681    57686       +5     
  Partials     1496     1496              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jingo88 Jingo88 merged commit aee23f7 into main Jul 23, 2025
103 checks passed
@Jingo88 Jingo88 deleted the PM-23722-remove-acct-sec-badge branch July 23, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants