Skip to content

[PM-23789][PM-237090][PM-23791][PM-23792] - [Web][Desktop][Browser] - Do not import cards if policy is enabled #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Jul 22, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23789
https://bitwarden.atlassian.net/browse/PM-23790
https://bitwarden.atlassian.net/browse/PM-23791
https://bitwarden.atlassian.net/browse/PM-23792

📔 Objective

This PR updates the import service to restrict any types that are restricted by any of the user's orgs. All clients use the same import component and import service so updating these and any dependencies is all that's required. All clients were tested manually to ensure no regressions were introduced.

📸 Screenshots

Screen.Recording.2025-07-22.at.1.51.42.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner July 22, 2025 21:12
@jaasen-livefront jaasen-livefront changed the title [PM-23789] - [Web][Desktop][Browser] - Do not import cards if policy is enabled [PM-23789][PM-237090][PM-23791][PM-23792] - [Web][Desktop][Browser] - Do not import cards if policy is enabled Jul 22, 2025
@jaasen-livefront jaasen-livefront requested review from Jingo88 and shane-melton and removed request for shane-melton July 22, 2025 21:15
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Logo
Checkmarx One – Scan Summary & Details52c30a26-a187-4cbd-b946-b8454284b6e2

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 37.57%. Comparing base (e99abb4) to head (d35a21b).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/importer/src/services/import.service.ts 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15740      +/-   ##
==========================================
- Coverage   37.58%   37.57%   -0.01%     
==========================================
  Files        3325     3320       -5     
  Lines       94840    94813      -27     
  Branches    14347    14344       -3     
==========================================
- Hits        35647    35630      -17     
+ Misses      57696    57687       -9     
+ Partials     1497     1496       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

djsmith85
djsmith85 previously approved these changes Jul 23, 2025
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good.

@jaasen-livefront
Copy link
Collaborator Author

@djsmith85 Just pushed a small cleanup commit if you wouldn't mind re-approving thanks!

Copy link

@jaasen-livefront jaasen-livefront merged commit fe1c040 into main Jul 23, 2025
89 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-23789 branch July 23, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants