-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-23789][PM-237090][PM-23791][PM-23792] - [Web][Desktop][Browser] - Do not import cards if policy is enabled #15740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #15740 +/- ##
==========================================
- Coverage 37.58% 37.57% -0.01%
==========================================
Files 3325 3320 -5
Lines 94840 94813 -27
Branches 14347 14344 -3
==========================================
- Hits 35647 35630 -17
+ Misses 57696 57687 -9
+ Partials 1497 1496 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good.
@djsmith85 Just pushed a small cleanup commit if you wouldn't mind re-approving thanks! |
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23789
https://bitwarden.atlassian.net/browse/PM-23790
https://bitwarden.atlassian.net/browse/PM-23791
https://bitwarden.atlassian.net/browse/PM-23792
📔 Objective
This PR updates the import service to restrict any types that are restricted by any of the user's orgs. All clients use the same import component and import service so updating these and any dependencies is all that's required. All clients were tested manually to ensure no regressions were introduced.
📸 Screenshots
Screen.Recording.2025-07-22.at.1.51.42.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes