[PM-23360] - Hide restricted cipher types in "File -> New Item" on desktop #15743
Conversation
jaasen-livefront
changed the title
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #15743 +/- ##
==========================================
+ Coverage 37.58% 37.60% +0.01%
==========================================
Files 3320 3321 +1
Lines 94806 94871 +65
Branches 14343 14350 +7
==========================================
+ Hits 35629 35672 +43
- Misses 57681 57702 +21
- Partials 1496 1497 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🎨 I don't think we need to modify this base super class. I don't see the _restrictedCipherTypes being used anywhere.
| export class MenuUpdateRequest { | ||
| activeUserId: string; | ||
| accounts: { [userId: string]: MenuAccount }; | ||
| restrictedCipherTypes: CipherType[]; |
There was a problem hiding this comment.
❓ Should we make this CipherType[] | null?
We set it to null in the app component when there are no accounts.
|
@shane-melton Thanks for the feedback, items are now addressed. |
jaasen-livefront
requested review from
shane-melton
and removed request for
justindbaur
|
…sktop (#15743) * hide restricted cipher types in file menu on desktop * fix bitwarden menu * small fixes
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23360
📔 Objective
This PR hides restricted cipher types in file menu on desktop.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes