-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-22790] Adds SendInput() Functionality to the Autotype Crate #15751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some small comments
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15751 +/- ##
==========================================
+ Coverage 37.59% 37.84% +0.25%
==========================================
Files 3321 3309 -12
Lines 94888 94023 -865
Branches 14356 14248 -108
==========================================
- Hits 35674 35586 -88
+ Misses 57717 56938 -779
- Partials 1497 1499 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22790
📔 Objective
Adds the ability to send UTF-16 encoded characters as keyboard events to the focused location in Windows for the new autotype feature. This feature is behind a feature flag.
Please note, the
println
will be removed in a future PR, for now it provides logging during development after input insertion:(We can eventually use the
GetLastError()
function for more precise error handling.)⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes