[PM-814] Breach Report Escape Characters

[AlexRubik]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-814

📔 Objective

Encode HIBP Breaches URL before using it for server request.

Hashtag acts as escape char in Breach Report. Emails with # return unrelated results. For example, running the report for "123#" returns same results as "123#[email protected]"

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 48790557-7ff5-415f-98ad-d54f9f13c23b

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.29%. Comparing base (1a0d3e3) to head (cafa471).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16264      +/-   ##
==========================================
+ Coverage   37.27%   37.29%   +0.01%     
==========================================
  Files        3373     3373              
  Lines       96665    96666       +1     
  Branches    14587    14587              
==========================================
+ Hits        36033    36049      +16     
+ Misses      59058    59043      -15     
  Partials     1574     1574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[djsmith85]

Requesting a review from @bitwarden/team-data-insights-and-reporting-dev as no automatic codeowner was assigned.

Based on the comment at the top of the api.service, all methods other than send()should be extracted into their own service. This would also ensure code-ownership would be accurately assigned for review, whenever the next changes for this API are made.

[Banrion]

Scope for capturing api service method extraction will be captured in this ticket, PM-25417

[djsmith85]

Approving as my comment will be addressed by future work: #16264 (review)

[AlexRubik]

Had to fix the spec file sorry.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud