Skip to content

Conversation

hmarquezbw
Copy link

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19907

📔 Objective

Updating empty state messages to better explain to the user.
Scenarios updated:

  • empty vault
  • empty favorites
  • empty trash
  • suspended organization - as it stands this message will override the empty trash message if user is currently selected into the suspended org and clicks on the trash. (Verifying with Danielle Flinn this is what we want for scenario behavior)

📸 Screenshots

Empty Vault:
image

Empty Favorites:
image

Empty Trash:
image

Suspended Org:
image

Trash in Suspended Org:
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@hmarquezbw hmarquezbw requested a review from a team as a code owner September 4, 2025 03:52
@hmarquezbw hmarquezbw added the needs-qa Marks a PR as requiring QA approval label Sep 4, 2025
@hmarquezbw hmarquezbw requested a review from Jingo88 September 4, 2025 03:52
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Logo
Checkmarx One – Scan Summary & Details10495ae8-d76c-41ec-9402-a8ab9209d7ce

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.32%. Comparing base (66f5700) to head (b0540e5).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/vault/individual-vault/vault.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16283      +/-   ##
==========================================
- Coverage   37.32%   37.32%   -0.01%     
==========================================
  Files        3366     3366              
  Lines       95725    95728       +3     
  Branches    14420    14422       +2     
==========================================
  Hits        35726    35726              
- Misses      58423    58426       +3     
  Partials     1576     1576              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Sep 4, 2025

Copy link
Contributor

@Jingo88 Jingo88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. just a few in line comments, and also some notes of things I picked up after looking at the figma and JIRA ticket.

  • It looks like the empty vault state should be when a user logs in and does not have any items ('My vault' + 'All items')
  • Missing a use case for when a user uses filters or a search it should show "no search results" (Note there's a diff between the copy in JIRA vs Figma for this use case that we may need clarity on)
  • Add missing SVG's. (Note may need to update the colors and strokes in the svg files. )

@@ -4701,7 +4722,10 @@
"description": "ex. Date this password was updated"
},
"organizationIsDisabled": {
"message": "Organization suspended"
"message": "Organization is suspended"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a new key/value here. Can delete the old key if it isn't used anywhere else.

@@ -71,7 +71,28 @@
class="tw-mt-6 tw-flex tw-h-full tw-flex-col tw-items-center tw-justify-start"
>
<bit-icon [icon]="noItemIcon" aria-hidden="true"></bit-icon>
<p>{{ "noItemsInList" | i18n }}</p>
<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add bitTypography to these and follow the typography of the text elements in figma

Since different svgs need to be imported, may make sense to keep some of the logic to determine the icon and text in the ts file?

: ("noItemsInVault" | i18n)
}}
</p>
<p class="tw-text-muted tw-w-[400px] tw-text-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for typography

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants