-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-19907] updated empty state messages for web #16283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16283 +/- ##
==========================================
- Coverage 37.32% 37.32% -0.01%
==========================================
Files 3366 3366
Lines 95725 95728 +3
Branches 14420 14422 +2
==========================================
Hits 35726 35726
- Misses 58423 58426 +3
Partials 1576 1576 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. just a few in line comments, and also some notes of things I picked up after looking at the figma and JIRA ticket.
- It looks like the empty vault state should be when a user logs in and does not have any items ('My vault' + 'All items')
- Missing a use case for when a user uses
filters
or asearch
it should show "no search results" (Note there's a diff between the copy in JIRA vs Figma for this use case that we may need clarity on) - Add missing SVG's. (Note may need to update the colors and strokes in the svg files. )
@@ -4701,7 +4722,10 @@ | |||
"description": "ex. Date this password was updated" | |||
}, | |||
"organizationIsDisabled": { | |||
"message": "Organization suspended" | |||
"message": "Organization is suspended" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a new key/value here. Can delete the old key if it isn't used anywhere else.
@@ -71,7 +71,28 @@ | |||
class="tw-mt-6 tw-flex tw-h-full tw-flex-col tw-items-center tw-justify-start" | |||
> | |||
<bit-icon [icon]="noItemIcon" aria-hidden="true"></bit-icon> | |||
<p>{{ "noItemsInList" | i18n }}</p> | |||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add bitTypography
to these and follow the typography of the text elements in figma
Since different svgs need to be imported, may make sense to keep some of the logic to determine the icon and text in the ts file?
: ("noItemsInVault" | i18n) | ||
}} | ||
</p> | ||
<p class="tw-text-muted tw-w-[400px] tw-text-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for typography
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19907
📔 Objective
Updating empty state messages to better explain to the user.
Scenarios updated:
📸 Screenshots
Empty Vault:

Empty Favorites:

Empty Trash:

Suspended Org:

Trash in Suspended Org:

⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes