Skip to content

Conversation

@jholland-livefront
Copy link
Collaborator

@jholland-livefront jholland-livefront commented Dec 29, 2025

🎟️ Tracking

PM-29511

📔 Objective

Remove ts-strict-ignore and update types for fido2-page-script.ts.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Logo
Checkmarx One – Scan Summary & Details9ece1641-cd9b-482f-99f3-9013cedfd74e

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.25%. Comparing base (cf1c322) to head (1848484).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...er/src/autofill/fido2/content/fido2-page-script.ts 29.41% 5 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18146      +/-   ##
==========================================
+ Coverage   42.24%   42.25%   +0.01%     
==========================================
  Files        3598     3599       +1     
  Lines      104474   104522      +48     
  Branches    15763    15782      +19     
==========================================
+ Hits        44135    44169      +34     
- Misses      58461    58465       +4     
- Partials     1878     1888      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const focusPromise = new Promise<void>((resolve) => {
focusListenerHandler = () => resolve();
globalContext.top.addEventListener("focus", focusListenerHandler);
globalContext.top!.addEventListener("focus", focusListenerHandler);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of a non null assertion here we can do an explicit null check

Suggested change
globalContext.top!.addEventListener("focus", focusListenerHandler);
const topWindow = globalContext.top;
const focusPromise = new Promise<void>((resolve) => {
focusListenerHandler = () => resolve();
if (topWindow) {
topWindow.addEventListener("focus", focusListenerHandler);
}
});

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Dec 30, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Dec 30, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants