-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove ts-strict-ignore from fido2 page
#18146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove ts-strict-ignore from fido2 page
#18146
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18146 +/- ##
==========================================
+ Coverage 42.24% 42.25% +0.01%
==========================================
Files 3598 3599 +1
Lines 104474 104522 +48
Branches 15763 15782 +19
==========================================
+ Hits 44135 44169 +34
- Misses 58461 58465 +4
- Partials 1878 1888 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const focusPromise = new Promise<void>((resolve) => { | ||
| focusListenerHandler = () => resolve(); | ||
| globalContext.top.addEventListener("focus", focusListenerHandler); | ||
| globalContext.top!.addEventListener("focus", focusListenerHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of a non null assertion here we can do an explicit null check
| globalContext.top!.addEventListener("focus", focusListenerHandler); | |
| const topWindow = globalContext.top; | |
| const focusPromise = new Promise<void>((resolve) => { | |
| focusListenerHandler = () => resolve(); | |
| if (topWindow) { | |
| topWindow.addEventListener("focus", focusListenerHandler); | |
| } | |
| }); |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |

🎟️ Tracking
PM-29511
📔 Objective
Remove
ts-strict-ignoreand update types forfido2-page-script.ts.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes