Skip to content

Conversation

@nikwithak
Copy link
Contributor

@nikwithak nikwithak commented Dec 30, 2025

🎟️ Tracking

PM-30301
PM-30302

📔 Objective

This migrates the cipher Create and Update operations to use the SDK instead of calling the APIs directly. Hidden behind the new feature flag pm-27632-cipher-crud-operations-to-sdk, which will gate all of the cipher basic operations once implemented.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Logo
Checkmarx One – Scan Summary & Details9aa42ad4-9e6a-4aec-a2ec-f2ee08709b1e

Great job! No new security vulnerabilities introduced in this pull request

@nikwithak nikwithak changed the title Vault/pm 27632/sdk cipher ops [PM-30301][PM-30302] Use SDK for Create and Update cipher operations Dec 31, 2025
@nikwithak nikwithak marked this pull request as ready for review January 1, 2026 00:35
@nikwithak nikwithak requested review from a team as code owners January 1, 2026 00:35
@nikwithak nikwithak marked this pull request as draft January 1, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants