Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Dec 31, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28901

📔 Objective

The switch to proof-of-decryption did not yet add an error toast, and so entering the wrong password resulted in no feedback. This PR re-adds an error toast for incorrect passwords.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten changed the title km/error toast crypto update [PM-28901] Re-add error toast Dec 31, 2025
@quexten quexten force-pushed the km/error-toast-crypto-update branch from 8454fba to 0371c0d Compare December 31, 2025 11:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

Logo
Checkmarx One – Scan Summary & Detailsf7f5b6ca-c2ef-4bf8-802f-a437238ce08a

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.27%. Comparing base (c6b0208) to head (9e12a5b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...d-migration/prompt-migration-password.component.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18161   +/-   ##
=======================================
  Coverage   42.27%   42.27%           
=======================================
  Files        3599     3599           
  Lines      104548   104552    +4     
  Branches    15780    15780           
=======================================
+ Hits        44194    44202    +8     
+ Misses      58473    58469    -4     
  Partials     1881     1881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten marked this pull request as ready for review December 31, 2025 11:41
@quexten quexten added ai-review Request a Claude code review and removed ai-review Request a Claude code review labels Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants