Skip to content

update pull request target workflow step #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aj-bw
Copy link
Member

@aj-bw aj-bw commented May 7, 2025

🎟️ Tracking

BRE-609

📔 Objective

update workflows to be compliant with pull_request_target workflow linter rule ahead of changing rule log level to error

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

cloudflare-workers-and-pages bot commented May 7, 2025

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: fd79142
Status: ✅  Deploy successful!
Preview URL: https://8f3fc0a5.contributing-docs.pages.dev
Branch Preview URL: https://bre-609-workflow-changes.contributing-docs.pages.dev

View logs

Copy link

github-actions bot commented May 7, 2025

Logo
Checkmarx One – Scan Summary & Details10361f0e-13c8-494a-94e7-f12a76b3e3d9

Great job, no security vulnerabilities found in this Pull Request

@aj-bw aj-bw marked this pull request as ready for review May 12, 2025 13:15
@aj-bw aj-bw requested a review from a team as a code owner May 12, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant