Skip to content

Amend standard output logging ADR #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justindbaur
Copy link
Member

@justindbaur justindbaur commented May 14, 2025

🎟️ Tracking

In connection with development of https://bitwarden.atlassian.net/browse/PM-12635.

📔 Objective

Revises direction to MEL.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions github-actions bot added the adr label May 14, 2025
Copy link

cloudflare-workers-and-pages bot commented May 14, 2025

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 820d546
Status: ✅  Deploy successful!
Preview URL: https://d7ab1e37.contributing-docs.pages.dev
Branch Preview URL: https://amend-adr-21-standard-output.contributing-docs.pages.dev

View logs

Copy link

github-actions bot commented May 14, 2025

Logo
Checkmarx One – Scan Summary & Details2fab0fb2-96ff-49f5-9749-9d3c1c4ffea2

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks but this makes sense. Gonna discuss this at a stakeholder sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants