[BRE-769] Add GitHub Actions workflow for publishing mobile releases #401
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
| STORE_VERSION_NUMBER: ${{ env.STORE_VERSION_NUMBER }} | ||
| run: | | ||
| if [ "$LATEST_DRAFT_VERSION" == "$STORE_VERSION_NAME ($STORE_VERSION_NUMBER)" ]; then | ||
| echo "Version $LATEST_DRAFT_VERSION is already released on Google Play Store" |
There was a problem hiding this comment.
⛏️ Reviewing this thinking ahead for iOS and noticed the reference to Google Play Store.
There was a problem hiding this comment.
Good catch, replaced the play store mentions.
| STORE_VERSION_NAME: ${{ env.STORE_VERSION_NAME }} | ||
| STORE_VERSION_NUMBER: ${{ env.STORE_VERSION_NUMBER }} | ||
| run: | | ||
| if [ "$LATEST_DRAFT_VERSION" == "$STORE_VERSION_NAME ($STORE_VERSION_NUMBER)" ]; then |
There was a problem hiding this comment.
🤔 Will be easier to maintain this long term if we compare individual values directly. That would also help us handle the Apple / Google restrictions by checking if version number matches first and then only checking Version Name if it's ios.
There was a problem hiding this comment.
I splitted it completely. Let me know if that works for you @vvolkgang :)
|
| STORE_VERSION_NUMBER: ${{ steps.get_store_versions.outputs.store_version_number }} | ||
| run: | | ||
| if [ "${{ inputs.project_type }}" == "ios" ]; then | ||
| if [ "$LATEST_DRAFT_VERSION_NAME" == "$STORE_VERSION_NUMBER" ] && [ "$LATEST_DRAFT_VERSION_NUMBER" == "$STORE_VERSION_NUMBER" ]; then |
There was a problem hiding this comment.
| if [ "$LATEST_DRAFT_VERSION_NAME" == "$STORE_VERSION_NUMBER" ] && [ "$LATEST_DRAFT_VERSION_NUMBER" == "$STORE_VERSION_NUMBER" ]; then | |
| if [ "$LATEST_DRAFT_VERSION_NAME" == "$STORE_VERSION_NAME" ] && [ "$LATEST_DRAFT_VERSION_NUMBER" == "$STORE_VERSION_NUMBER" ]; then |
|
|
||
| echo "Previous run processed: $previous_release_tag (changed from: $previous_initial_state to: $previous_changed_to)" | ||
| else | ||
| echo "::error:: No valid release-info.json found in previous artifact" |
There was a problem hiding this comment.
Run summary makes it look like it silently failed because of this output, we could transition this to a ::warning:: instead
| echo "::error:: No valid release-info.json found in previous artifact" | |
| echo "::warning::No valid release-info.json found in previous artifact" |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-769
📔 Objective
Add GitHub Actions workflow for publishing mobile releases. Yhis action will be used in iOS and Android repos:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes