Skip to content

[PM-18448] self-host: support other external database providers #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dionysius
Copy link

@dionysius dionysius commented Feb 19, 2025

📔 Objective

Support other external database providers supported by bitwarden server: https://github.com/bitwarden/server/blob/main/src/Admin/Startup.cs#L50-L68

Optimally we would reorganise the values.yaml's database property to make navigating it a bit cleaner. But the current implementation uses minimal changes and is backwards-compatible even if databaseProvider is missing. There may be a way to simplify {{- if eq "sqlserver" (default "sqlserver" .Values.databaseProvider) }}.

In my opinion supported provider sqlite doesn't make much sense in a helm managed kubernetes environment though it is technically almost possible with the current PR (missing volume setup) - hence not documented and the focus being external servers.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-18448

@bitwarden-bot bitwarden-bot changed the title self-host: support other external database providers [PM-18448] self-host: support other external database providers Feb 19, 2025
@bitwarden-bot bitwarden-bot added in-product-review Community PR is being reviewed by Bitwarden's Product team community-pr labels Feb 19, 2025
@dionysius dionysius force-pushed the support_external_db_providers branch 2 times, most recently from 3c3f895 to 120cf36 Compare February 19, 2025 19:55
@dionysius dionysius force-pushed the support_external_db_providers branch from 120cf36 to 7c9699d Compare February 19, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr in-product-review Community PR is being reviewed by Bitwarden's Product team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants