[PM-19673] Add nodeSelector and tolerations

[Invincibear]

🎟️ Tracking

This is a re-implementation of #168, a PR that was never merged in due to not signing the disclosure agreement (which I have)

📔 Objective

Adds support to all templates for specifying nodeSelector & tolerations

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[S-Kakar]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-19673

[Invincibear]

I forgot to update charts/sm-operator/values.yaml to tolerations: [], I pushed the changes and am waiting for tests to run.

charts/self-host$ helm lint .
==> Linting .

1 chart(s) linted, 0 chart(s) failed

charts/sm-operator$ helm lint .
==> Linting .

1 chart(s) linted, 0 chart(s) failed

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Checkmarx One – Scan Summary & Details – ce441793-338e-41f4-ad94-5dd7316f9130

Great job, no security vulnerabilities found in this Pull Request

[Copilot]

Pull Request Overview

Adds support for specifying nodeSelector and tolerations across both the sm-operator and self-host Helm charts.

• Extended the values schema in both charts to include nodeSelector and tolerations with sensible defaults.
• Updated values.yaml for self-host to define these defaults at global and per-component levels.
• Injected conditional blocks in all relevant templates to render nodeSelector and tolerations into pod specs.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
charts/sm-operator/values.schema.json	Added nodeSelector and tolerations under containers
charts/sm-operator/templates/deployment.yaml	Injected nodeSelector/tolerations into deployment spec
charts/self-host/values.yaml	Defined global and component defaults for selectors and tolerations
charts/self-host/values.schema.json	Expanded schema with new properties for all components
charts/self-host/templates/web.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/sso.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/scim.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/pre-install-secret-sql.yaml	Enabled selectors and tolerations in hook spec
charts/self-host/templates/pre-install-job.yaml	Enabled selectors and tolerations in job spec
charts/self-host/templates/pre-install-db-migrator-job.yaml	Enabled selectors and tolerations in migrator job spec
charts/self-host/templates/post-install-db-migrator-job.yaml	Enabled selectors and tolerations in migrator job spec
charts/self-host/templates/post-delete-hook.yaml	Enabled selectors and tolerations in hook spec
charts/self-host/templates/notifications.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/mssql.yaml	Enabled selectors and tolerations for mssql pods
charts/self-host/templates/identity.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/icons.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/events.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/attachments.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/api.yaml	Added conditional rendering of selectors and tolerations
charts/self-host/templates/admin.yaml	Added conditional rendering of selectors and tolerations

Comments suppressed due to low confidence (3)

charts/self-host/templates/web.yaml:28

• Because general.nodeSelector defaults to {} (a non-nil map), this if condition always evaluates to true, resulting in an empty nodeSelector block being rendered even when no selector is provided. Consider checking for non-empty values (e.g., using len) or allowing null defaults.

{{- if or .Values.component.web.nodeSelector .Values.general.nodeSelector }}

charts/self-host/templates/sso.yaml:28

• [nitpick] This block is duplicated across many templates. Consider extracting a helper in _helpers.tpl to render nodeSelector and tolerations, reducing repetition and easing future updates.

{{- if or .Values.component.sso.nodeSelector .Values.general.nodeSelector }}

[mimartin12]

@Invincibear , working through some CI blockers, we will get this merged once CI passes 😄 .

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud