Skip to content

Conversation

OneUpWallStreet
Copy link

🎟️ Tracking

I'm a heavy user of Bitwarden and I think this could be a pretty useful feature. I haven't linked it to a specific issue or Jira ticket, but I noticed that while credit card numbers are hidden by default, the SSN field in identity items isn't. This change comes from my own experience using the app.

📔 Objective

I feel like the SSN field in identity should be hidden by default because its value is arguably even more sensitive than a password. It doesn't make much sense for it to be in plain text when other sensitive fields, like credit card numbers, are already protected.

I think there's still some work to be done to align it with Bitwarden's design principles. One area for example I'm still not 100% on is adding the proper eventType for the SSN toggle. Any feedback or pointers on that would be awesome.

📸 Screenshots

Before (SSN Visible) After (SSN Hidden by Default)
Before Screenshot After Screenshot

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-18596

@bitwarden-bot bitwarden-bot changed the title feat: Hide SSN Field by Default on Identity Screen [PM-18596] feat: Hide SSN Field by Default on Identity Screen Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants