[PM-19479] Client-managed Repository traits #213
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 69.94% 69.36% -0.59%
==========================================
Files 214 218 +4
Lines 16935 17145 +210
==========================================
+ Hits 11846 11892 +46
- Misses 5089 5253 +164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
dani-garcia
force-pushed
the
ps/state-traits
branch
from
5f13cc1 to
778bc50
Compare
dani-garcia
force-pushed
the
ps/state-traits
branch
from
778bc50 to
34daa77
Compare
dani-garcia
changed the title
Implement demo cipher repository
dani-garcia
force-pushed
the
ps/state-traits
branch
from
34daa77 to
9d3ce7f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19479
📔 Objective
Implement a generic trait for accessing the application's data storage directly. Because we want the store access to be typed, but
bitwarden_coreisn't aware of the models,bitwarden_coreonly implements a generic way to set and retrieve genericimpl Repository<T>instances. Then it's up to each team/feature crates to define which models and which stores are available.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes