[PM-21918] update send api models to support new email field#5895
Merged
[PM-21918] update send api models to support new email field#5895
email field#5895Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5895 +/- ##
==========================================
+ Coverage 58.58% 58.72% +0.14%
==========================================
Files 1920 1922 +2
Lines 85264 85328 +64
Branches 7632 7649 +17
==========================================
+ Hits 49953 50112 +159
+ Misses 33465 33356 -109
- Partials 1846 1860 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
djsmith85
previously approved these changes
Jul 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
audreyality
commented
Aug 15, 2025
jaasen-livefront
previously approved these changes
Aug 15, 2025
Collaborator
jaasen-livefront
left a comment
There was a problem hiding this comment.
Approve vault change
itsadrago
previously approved these changes
Dec 23, 2025
itsadrago
previously approved these changes
Dec 23, 2025
…com:bitwarden/server into tools/pm-21918/send-authentication-commands merge latest from main
itsadrago
approved these changes
Dec 23, 2025
mkincaid-bw
requested changes
Dec 23, 2025
Contributor
There was a problem hiding this comment.
Default value should be NULL
Suggested change
| @AuthType TINYINT = 2 | |
| @AuthType TINYINT = NULL |
Contributor
There was a problem hiding this comment.
Default value should be NULL
Suggested change
| @AuthType TINYINT = 2 | |
| @AuthType TINYINT = NULL |
mkincaid-bw
approved these changes
Dec 24, 2025
Contributor
mkincaid-bw
left a comment
There was a problem hiding this comment.
I see the updates now, LGTM
mzieniukbw
approved these changes
Dec 24, 2025
shane-melton
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21918
https://bitwarden.atlassian.net/browse/PM-29783
https://bitwarden.atlassian.net/browse/PM-29789
https://bitwarden.atlassian.net/wiki/spaces/EN/pages/2164654083/Email-authenticated+Sends+-+Updated
Implements #5895
📔 Objective
Original
Update send API models to support email/OTP administration.
Important
This PR includes documentation for the related models. I mostly inferred what each of these are. Please focus on them during review to confirm that the comments are correct.
Updated
In a recent tech breakdown it was decided we would also add an explicit property
AuthTypethat will allow the client to determine the authentication strategy to use (email OTP, password, or none) without relying on the presence or absence ofEmailsorPasswordproperties in order to infer the strategy. The latest iteration of this PR accomplishes the following:AuthTypeproperty is not setEmailswere also updated to include theAuthTypepropertyFIXMEswere addressed: One overload ofToSendwas renamed toUpdateSendandGlobalSettingswere eliminated from one of the updated filesAuthTypeinference, explicit assignment, and other behavior not formerly covered inSendsController⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes