Skip to content

[PM-21918] update send api models to support new email field #5895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

audreyality
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21918

📔 Objective

Update send API models to support email/OTP administration.

Important

This PR includes documentation for the related models. I mostly inferred what each of these are. Please focus on them during review to confirm that the comments are correct.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner May 28, 2025 18:34
@audreyality audreyality added the hold Hold this PR or item until later; DO NOT MERGE label May 28, 2025
@audreyality audreyality marked this pull request as draft May 28, 2025 18:35
@audreyality
Copy link
Member Author

📝 This PR may wait to merge until the CLI logic is stable.

Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc9b0276d-80ee-4a06-8165-fbaeda4c5661

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.50%. Comparing base (f3e637c) to head (2d625f6).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/Api/Tools/Models/Request/SendRequestModel.cs 16.66% 4 Missing and 1 partial ⚠️
src/Api/Tools/Models/Response/SendResponseModel.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5895      +/-   ##
==========================================
- Coverage   47.51%   47.50%   -0.01%     
==========================================
  Files        1662     1662              
  Lines       75215    75228      +13     
  Branches     6761     6763       +2     
==========================================
+ Hits        35737    35738       +1     
- Misses      38015    38026      +11     
- Partials     1463     1464       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Hold this PR or item until later; DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant