[PM 18208]Cancel self-serve trials with no payment method #5916
Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5916 +/- ##
==========================================
- Coverage 47.74% 47.73% -0.01%
==========================================
Files 1665 1665
Lines 75008 75019 +11
Branches 6755 6756 +1
==========================================
Hits 35814 35814
- Misses 37734 37745 +11
Partials 1460 1460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -417,6 +417,18 @@ private async Task<Subscription> CreateSubscriptionAsync( | |||
| TrialPeriodDays = subscriptionSetup.SkipTrial ? 0 : plan.TrialPeriodDays | |||
| }; | |||
|
|
|||
| // Only set trial_settings.end_behavior.missing_payment_method to "cancel" if there is no payment method | |||
| if (string.IsNullOrEmpty(customer.InvoiceSettings?.DefaultPaymentMethodId)) | |||
There was a problem hiding this comment.
Is PayPal a valid payment method for this scenario? If so, this would not catch a PayPal customer.
| @@ -76,6 +76,25 @@ public async Task Credit(User user, decimal amount) | |||
| }; | |||
|
|
|||
| await stripeAdapter.CustomerUpdateAsync(customer.Id, options); | |||
|
|
|||
| // If the user has a subscription in trial, update the trial settings | |||
| if (!string.IsNullOrEmpty(user.GatewaySubscriptionId)) | |||
There was a problem hiding this comment.
❓ Isn't create_invoice the default setting for this switch? You can verify this by creating a subscription against main and checking the trial_settings. If so, this block of code is unnecessary.
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18208
📔 Objective
Acceptance criteria
GIVEN: a free trial is being created without a payment method (applies to PM/SM, Families, Teams, and Enterprise)
THEN: trial_settings.end_behavior.missing_payment_method should be set to cancel
GIVEN: ALL the following
a subscription is in a trialing status
the trial_settings.end_behavior.missing_payment_method is set to cancel
WHEN: account credit is added (any amount)
THEN: update trial_settings.end_behavior.missing_payment_method to create-invoice
Description
The finance and billing teams have requested that the following changes be made to how we handle payment optional trials in order to better align with accounting best practices.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes