Skip to content

feat(change-password-component): Change Password Update [18720] - Now… #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Patrick-Pimentel-Bitwarden
Copy link
Contributor

… sending back accepted mp policies on base validator

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

… sending back accepted mp policies on base validator
Copy link

sonarqubecloud bot commented Jun 6, 2025

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.

Project coverage is 10.81%. Comparing base (8165651) to head (7ed1900).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...work/AdminConsole/Repositories/PolicyRepository.cs 0.00% 23 Missing ⚠️
...ries/PolicyReadAcceptedOrConfirmedByUserIdQuery.cs 0.00% 16 Missing ⚠️
src/Core/Context/CurrentContext.cs 0.00% 11 Missing ⚠️
...pper/AdminConsole/Repositories/PolicyRepository.cs 0.00% 9 Missing ⚠️
...nConsole/Services/Implementations/PolicyService.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5929       +/-   ##
===========================================
- Coverage   47.52%   10.81%   -36.71%     
===========================================
  Files        1666      969      -697     
  Lines       74910    43943    -30967     
  Branches     6736     3471     -3265     
===========================================
- Hits        35599     4752    -30847     
- Misses      37853    39095     +1242     
+ Partials     1458       96     -1362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Logo
Checkmarx One – Scan Summary & Details38061de3-f341-492b-9350-3255bf11bb0c

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant