Conversation
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
|
CI is failing because I don't have the correct permissions. |
addisonbeck
left a comment
There was a problem hiding this comment.
I'm assuming you didn't test this yourself. What steps would you recommend we take to test?
@addisonbeck, Sorry about the long reply. I was on vacation and just got back. The easy way to test this would be to build without
The above picture is an example of what you should see if this works. |
addisonbeck
left a comment
There was a problem hiding this comment.
I'm okay sending this to QA. We'll need a second opinion from @vgrassia or someone else from the BRE team first though.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6547 +/- ##
==========================================
- Coverage 56.49% 56.48% -0.01%
==========================================
Files 2003 2003
Lines 88287 88287
Branches 7881 7881
==========================================
- Hits 49874 49873 -1
- Misses 36581 36582 +1
Partials 1832 1832 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@addisonbeck @vgrassia I do not have permission to kick off the required CI. could one of you do so and merge? |
vgrassia
left a comment
There was a problem hiding this comment.
The linter is failing because of the formatting.
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Co-authored-by: Addison Beck <[email protected]>
Co-authored-by: Addison Beck <[email protected]>
Co-authored-by: Addison Beck <[email protected]>
Co-authored-by: Addison Beck <[email protected]>
Co-authored-by: Vince Grassia <[email protected]>
Co-authored-by: Vince Grassia <[email protected]>






🎟️ Tracking
N/A I thought this would be fun, and increase the security of my hosted server.
📔 Objective
This will allow clients and browsers to use quantum resistant TLS for connections if they support it and also enables TLS 1.3 support (with 1.2 fallback) for clients supporting TLS 1.3. This change was inspired by this Cloudflare post about the state of the post-quantum internet in 2025. I noticed that my browser was just using X25519 and I knew how to fix it, so this PR was born.
This is the reasoning behind the specific version of MLKEM over X25519 that is set as default.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes