-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly set viewports and render targets for Apple Vision Pro #3325
fix: properly set viewports and render targets for Apple Vision Pro #3325
Conversation
f9d3e98
to
df25a07
Compare
Also number of eyes is not arbitrary, so you don't have to use dynamic array type of containers for viewports at all... Consider what's maximum number of eyes you will ever have on VisionOS, and then create something more appropriate. |
Hey @bkaradzic thanks for reviewing, I removed STL references and allocated a static C-like array for the viewports. |
ba7a8ff
to
93707dd
Compare
fix: do not use STL
93707dd
to
aed66e9
Compare
Hey @bkaradzic, anything you would like to see changed in this PR? Just so you know, we are moving forward with the integration (currently by cherry-picking the changes) and we have made some progress. I'm attaching a video of Babylon Native running on the device, we still need to figure out 6DOF but it's on the Babylon side. ScreenRecording.July.19.2024.mov |
fix: do not use STL
fix: do not use STL
This PR partially fixes issues with bgfx rendering on Apple Vision Pro devices. It aims to fix issues described in this Tweet: https://x.com/o_kwasniewski/status/1811313113527992391
Here is the outline of what this PR is doing:
layer_renderer
BFGX does not support .dedicated
layout at this point