feat(bluetooth): support for multiple batteries as sensors #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineGS
force-pushed
the
multiple_battery_and_sensors
branch
from
7a0794d to
48f01b5
Compare
Owner
|
I really love your approach of using DBus for controlling the bluetooth devices using the Bluez API. For the battery sensors, I've seen some people also requesting it even though there is a dedicated module just for showing the batteries, so it's nice that you included them. I noticed a few PEP8 issues during the checks. If you'd like, I can merge the PR and fix those myself. |
AntoineGS
force-pushed
the
multiple_battery_and_sensors
branch
from
48f01b5 to
e5662e4
Compare
Contributor
Author
|
PEP8 is now passing! I did have to suppress one of the warnings as I felt that it did not make sense to split that code up to reduce the input parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #216
It includes PR #218
Here is how it looks in Home Assistant:
I kept the first battery reporting as an attribute as to not introduce a breaking change.