Time issue #170
Merged
Time issue #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a test case for the hour overflow issue.
Test case:
```
mysql> CREATE TABLE t (c TIME);
Query OK, 0 rows affected (0,018 sec)
mysql> INSERT INTO t values ('-507:48:27');
Query OK, 1 row affected (0,009 sec)
```
The way we currently parse hour at time_from_packed can overflow if the amount of hours is greater than 255 because the hour field from time struct is a u8. This commit fixes the issue by converting the hours to days and hours. Fixes: blackbeam#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysql-time: hour overflow
The way we currently parse hour at time_from_packed can overflow if
the amount of hours is greater than 255 because the hour field from
time struct is a u8.
This commit fixes the issue by converting the hours to days and hours.
Fixes: #169