Issue#401 Adding required definitions for MariaDB metadata skipping #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining MariadbCapabilities completely like standard client capability flags. MariadbCapabilities contains all exsisting to the moment MariaDB specific/extended capabilities. Also adding new constructor for HandshakeResponse class to assemble the packet with MariaDB extended capabilities.
lawrinn
changed the title
extended capabilities. Also fixed Handshake's serialize method to write them if they are present.
blackbeam
added a commit
that referenced
this pull request
Jul 31, 2025
blackbeam
added a commit
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part of the implementation of the Issue#401
The solution requires changes to both mysql_common and to mysql-simple/async. This is the part for the common, obviously.
The change is independent and does not require changes in simple/async. Both can be built with it and tests pass without changes.
The patch is defining MariadbCapabilities completely in analogy with standard client capability flags. MariadbCapabilities contains all existing to the moment MariaDB specific/extended capabilities.
Also adding new constructor for HandshakeResponse class to assemble the packet with MariaDB extended capabilities.
I'd probably like to hear comments to this one before submitting the counterpart for simple.
The PR is submitted on behalf of my employer, MariaDB Corporation plc. We are planning further support and implement MariaDB specific features.