Added Wasm support #111
Merged
Added Wasm support #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly an oversight in the migration to
package:web. In their migration (https://dart.dev/interop/js-interop/package-web#conditional-imports) they state that:This was not done in our initial migration and thus Wasm didn't work properly although the code already can. This PR fixes that and also adjusts the test runner & tests themselves to support this.
One note on the test adjustment: The port returned from the hybrid code that simulates a server accepting Stomp connections comes back as a
doublein a Wasm environment and this is why we now check the type of the returned port and convert it accordingly.