Skip to content

baddns 2.0.0 / badsecrets 1.0.0 compatibility#2933

Draft
liquidsec wants to merge 5 commits into3.0from
badsecrets-baddns-major-version-compat
Draft

baddns 2.0.0 / badsecrets 1.0.0 compatibility#2933
liquidsec wants to merge 5 commits into3.0from
badsecrets-baddns-major-version-compat

Conversation

@liquidsec
Copy link
Collaborator

Summary

  • baddns: Pass severity/confidence directly from library instead of mapping (baddns 2.0.0 aligns with BBOT's levels)
  • baddns: Replace only_high_confidence boolean with min_severity/min_confidence threshold options (defaults: LOW/MODERATE)
  • baddns_direct: Inherit from baddns base module instead of duplicating setup/threshold logic
  • badsecrets: Add ASPNET_Resource to technology detection (new module in badsecrets 1.0.0)
  • Version bumps: baddns~=2.0.0, badsecrets~=1.0.0

Note: Tests will fail until baddns 2.0.0 and badsecrets 1.0.0 are published to PyPI.

@liquidsec
Copy link
Collaborator Author

do not merge until badsecrets 1.0 and baddns 2.0 are released.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs badsecrets-baddns-major-version-compat (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.31ms 4.36ms +1.0%
Bloom Filter Large Scale Dns Brute Force 17.98ms 18.09ms +0.6%
Large Closest Match Lookup 344.02ms 331.14ms -3.7%
Realistic Closest Match Workload 180.26ms 179.28ms -0.5%
Event Memory Medium Scan 1769 B/event 1768 B/event -0.0%
Event Memory Large Scan 1757 B/event 1757 B/event +0.0%
Event Validation Full Scan Startup Small Batch 448.81ms 451.76ms +0.7%
Event Validation Full Scan Startup Large Batch 704.72ms 715.16ms +1.5%
Make Event Autodetection Small 24.58ms 24.88ms +1.2%
Make Event Autodetection Large 249.88ms 252.28ms +1.0%
Make Event Explicit Types 10.53ms 10.57ms +0.4%
Excavate Single Thread Small 3.579s 3.566s -0.4%
Excavate Single Thread Large 8.926s 8.799s -1.4%
Excavate Parallel Tasks Small 3.762s 3.765s +0.1%
Excavate Parallel Tasks Large 6.898s 6.898s +0.0%
Is Ip Performance 3.12ms 3.23ms +3.3%
Make Ip Type Performance 11.18ms 11.25ms +0.7%
Mixed Ip Operations 4.45ms 4.55ms +2.2%
Typical Queue Shuffle 60.10µs 59.13µs -1.6%
Priority Queue Shuffle 696.02µs 681.83µs -2.0%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

- Add submodule auto-filter: disable submodules whose max severity/confidence
  is below configured thresholds (avoids running expensive submodules for nothing)
- Create baddns.yml base preset (CNAME, MX, TXT) and baddns-heavy.yml (all submodules)
- Rename spider-intense→spider-heavy, baddns-intense→baddns-heavy
- Fix baddns_zone default min_severity to INFORMATIONAL (NSEC/zonetransfer need it)
- Update kitchen-sink.yml, remove stale enable_references v1.x config
- Fix baddns_zone NSEC test (bad.dns→bad.com for tldextract compatibility)
- Fix baddns_direct test (updated signature matcher for baddns 2.0)
- Update all preset warning messages and docs references
…r-version-compat

# Conflicts:
#	bbot/modules/baddns_direct.py
#	bbot/modules/badsecrets.py
#	docs/modules/lightfuzz.md
#	docs/scanning/presets_list.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants