Conversation
- BaseTarget no longer subclasses RadixTarget; uses composition instead - Rename strict_dns_scope -> strict_scope everywhere - Update host_size_key import path for radixtarget 4.x - Handle radixtarget 4.x API changes (strings-only, no _add, hash is int) - Skip acl_mode when strict_scope is True (mutually exclusive in 4.x) - Update test assertions for new hash values and string-based hosts Work in progress - more test fixes needed.
Performance Benchmark Report
|
…cope filtering - Remove ASN event emission (already handled by asn report module via asndb) - Replace scope_distance_modifier+filter_event with proper in_scope_only class attr - Dynamically set scope_distance_modifier=1 when in_scope_only option is disabled - Add tests for in_scope_only=True and in_scope_only=False behavior
| @property | ||
| def hash(self): | ||
| """Blacklist hash includes both hosts and regex patterns.""" | ||
| h = (self._rt.hash ^ _fnv1a_64(sorted(r.pattern for r in self.blacklist_regexes))) & 0xFFFFFFFFFFFFFFFF |
There was a problem hiding this comment.
is the & 0xFFFFFFFFFFFFFFFF necessary?
There was a problem hiding this comment.
In Python, integers have arbitrary precision — the ^ (XOR) of two values could produce a result wider than 64 bits depending on the inputs. The mask ensures we get a consistent unsigned 64-bit value.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## asn-as-targets #2957 +/- ##
================================================
- Coverage 92% 92% -0%
================================================
Files 409 436 +27
Lines 34189 36158 +1969
================================================
+ Hits 31129 32917 +1788
- Misses 3060 3241 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
No description provided.