Skip to content

Fix double-request bug in pgp module#2961

Merged
liquidsec merged 1 commit into3.0from
pgp-fix
Mar 6, 2026
Merged

Fix double-request bug in pgp module#2961
liquidsec merged 1 commit into3.0from
pgp-fix

Conversation

@liquidsec
Copy link
Collaborator

@liquidsec liquidsec commented Mar 6, 2026

The pgp module was using request_batch() to fetch URLs but then re-fetching each URL again inside the loop. Removed the redundant request. Also removed a stale TODO.

#2960

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs pgp-fix (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.28ms 4.26ms -0.6%
Bloom Filter Large Scale Dns Brute Force 18.10ms 17.70ms -2.2%
Large Closest Match Lookup 364.98ms 354.97ms -2.7%
Realistic Closest Match Workload 196.37ms 192.41ms -2.0%
Event Memory Medium Scan 1769 B/event 1766 B/event -0.2%
Event Memory Large Scan 1757 B/event 1757 B/event +0.0%
Event Validation Full Scan Startup Small Batch 474.56ms 491.22ms +3.5%
Event Validation Full Scan Startup Large Batch 763.29ms 767.95ms +0.6%
Make Event Autodetection Small 30.67ms 31.19ms +1.7%
Make Event Autodetection Large 312.55ms 315.33ms +0.9%
Make Event Explicit Types 13.66ms 14.14ms +3.5%
Excavate Single Thread Small 4.057s 4.034s -0.6%
Excavate Single Thread Large 9.625s 9.840s +2.2%
Excavate Parallel Tasks Small 4.182s 4.196s +0.3%
Excavate Parallel Tasks Large 7.291s 7.322s +0.4%
Is Ip Performance 3.18ms 3.18ms +0.2%
Make Ip Type Performance 11.40ms 11.34ms -0.5%
Mixed Ip Operations 4.47ms 4.47ms -0.2%
Typical Queue Shuffle 64.97µs 62.08µs -4.4%
Priority Queue Shuffle 711.98µs 694.48µs -2.5%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@liquidsec liquidsec merged commit 6b1f8bb into 3.0 Mar 6, 2026
13 of 14 checks passed
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91%. Comparing base (b90f1d3) to head (3f7a2fa).
⚠️ Report is 10 commits behind head on 3.0.

Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #2961   +/-   ##
=====================================
- Coverage     92%     91%   -0%     
=====================================
  Files        436     436           
  Lines      36320   36333   +13     
=====================================
- Hits       33059   33057    -2     
- Misses      3261    3276   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants