canvas indexing#59
Merged
blacksmithgu merged 8 commits intoblacksmithgu:masterfrom Jul 17, 2024
GamerGirlandCo:feat/canvas
Merged
canvas indexing#59blacksmithgu merged 8 commits intoblacksmithgu:masterfrom GamerGirlandCo:feat/canvas
blacksmithgu merged 8 commits intoblacksmithgu:masterfrom
GamerGirlandCo:feat/canvas
Conversation
blacksmithgu
approved these changes
Jul 17, 2024
| throw new Error("Encountered unrecognized import result type: " + (result as any).type); | ||
| } | ||
|
|
||
| public storeCanvas(data: Canvas) { |
Owner
There was a problem hiding this comment.
Haha, there really are quite a few layers of metadata in a canvas file...
| ////////////// | ||
| return page.build(); | ||
| } | ||
| export function markdownSourceImport(path: string, markdown: string, metadata: CachedMetadata) { |
Owner
There was a problem hiding this comment.
This function should be annotated with what type it returns (looks like a map of the major metadata types?).
Owner
|
I've done some formatting (via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as seen in blacksmithgu/obsidian-dataview#1803 :)
please let me know what i can add or improve!