feat(docker): Add support for multi-platform build #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belsakn
reviewed
Sep 14, 2021
| @@ -35,6 +35,7 @@ type ( | |||
| Provider Provider `json:"-"` | |||
| EnvVariables []EnvVariable `json:"-"` | |||
| Mounts []*Mount `json:"mounts"` | |||
| Platforms string `json:"platforms"` | |||
There was a problem hiding this comment.
This should be an array?
Suggested change
| Platforms string `json:"platforms"` | |
| Platforms []string `json:"platforms"` |
There was a problem hiding this comment.
Yeah! That will make things easier
| job, err = s.jobs.Find(job.ID) | ||
| if err != nil { | ||
| return nil, err | ||
| for platform := range strings.Split(repo.Platforms, ";") { |
There was a problem hiding this comment.
Suggested change
| for platform := range strings.Split(repo.Platforms, ";") { | |
| for _,platform := range repo.Platforms { |
|
@belsakn |
|
@MrCyjaneK will check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request close #559
Since docker already support multiarch by using qemu, it would be cool to have abstruse support it also,
Commands required to setup:
Currently there is no gui for setting platforms (and it is not likely that I'll do that.. I have no idea how frontend works), so in database you need to update
platformsrow with something like:linux/amd64;linux/arm64After that trigger a build and you will see this: