fix: add option to use transfer_from #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e transfer_from on backstop donate
mootz12
requested changes
Dec 17, 2024
pool/src/pool/submit.rs
Outdated
Comment on lines
189
to
191
| #[test] | ||
| #[should_panic(expected = "Error(Contract, #9)")] | ||
| fn test_submit_use_allowance() { |
There was a problem hiding this comment.
can we add a happy path transfer_from test that validates tokens are successfully transferred and the allowance is spent?
Then, can we rename this test to specify why it fails - IE test_submit_use_allowance_no_allowance
Ryang-21
force-pushed
the
transfer-from
branch
from
e94e00c to
5ef9fd4
Compare
mootz12
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transfer_fromto be used #5submit_with_allowancethat implements transfers from the user to pool using transfer_fromtransferfunction call on the Backstop'sdonatefunction totransfer_from