chore: use strongly typed events and improve auction events #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspluna
approved these changes
Dec 17, 2024
| /// * user - The auction user | ||
| /// * auction_type - The type of auction | ||
| /// * auction_data - The auction data | ||
| pub fn new_auction(e: &Env, user: Address, auction_type: u32, auction_data: AuctionData) { |
There was a problem hiding this comment.
do we want to emit the percent liquidated as well?
There was a problem hiding this comment.
Liquidation percent is not auction agnostic, so it is currently left out.
While the data is potentially useful, it is also indexable via transactions, given liquidation percent is an argument, and auction data is the return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.