Skip to content

Conversation

@jamadeo
Copy link
Collaborator

@jamadeo jamadeo commented Nov 14, 2025

This started out as just a fix for windows, but we can simplify a lot here.

Copilot AI review requested due to automatic review settings November 14, 2025 17:50
Copilot finished reviewing on behalf of jamadeo November 14, 2025 17:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the binary path resolution logic to focus specifically on finding the goosed binary, removing the more general getBinaryPath function. The changes simplify the API surface by removing unused functionality for resolving other binaries like npx and uvx.

Key Changes

  • Renamed getBinaryPath to getGoosedBinaryPath and removed support for resolving multiple binary types
  • Added target/debug to the search paths for development builds
  • Removed the get-binary-path IPC handler and corresponding preload API

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ui/desktop/src/utils/pathUtils.ts Simplified binary path resolution to only handle goosed, removed security checks that were overly defensive, added target/debug search path
ui/desktop/src/preload.ts Removed getBinaryPath from the Electron API type and IPC invocation
ui/desktop/src/main.ts Removed get-binary-path IPC handler and updated import
ui/desktop/src/goosed.ts Updated to use renamed getGoosedBinaryPath function
ui/desktop/src/components/settings/extensions/utils.test.ts Removed mockElectron definition that is no longer needed

Copilot AI review requested due to automatic review settings November 14, 2025 19:11
Copilot finished reviewing on behalf of jamadeo November 14, 2025 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@jamadeo jamadeo changed the title Do a better job of finding goosed on windows Simplify finding goosed Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants