-
Notifications
You must be signed in to change notification settings - Fork 2k
Simplify finding goosed
#5739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Simplify finding goosed
#5739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the binary path resolution logic to focus specifically on finding the goosed binary, removing the more general getBinaryPath function. The changes simplify the API surface by removing unused functionality for resolving other binaries like npx and uvx.
Key Changes
- Renamed
getBinaryPathtogetGoosedBinaryPathand removed support for resolving multiple binary types - Added
target/debugto the search paths for development builds - Removed the
get-binary-pathIPC handler and corresponding preload API
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/desktop/src/utils/pathUtils.ts | Simplified binary path resolution to only handle goosed, removed security checks that were overly defensive, added target/debug search path |
| ui/desktop/src/preload.ts | Removed getBinaryPath from the Electron API type and IPC invocation |
| ui/desktop/src/main.ts | Removed get-binary-path IPC handler and updated import |
| ui/desktop/src/goosed.ts | Updated to use renamed getGoosedBinaryPath function |
| ui/desktop/src/components/settings/extensions/utils.test.ts | Removed mockElectron definition that is no longer needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
goosed
This started out as just a fix for windows, but we can simplify a lot here.