More time for goosed #5746
Open
More time for goosed #5746
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanesq
approved these changes
Nov 14, 2025
Copilot finished reviewing on behalf of
jamadeo
November 14, 2025 19:15
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the startup timeout for the goosed server from 3 seconds to 10 seconds to accommodate macOS notarization checks that can take up to ~3.5 seconds on the author's machine.
- Changed
maxAttemptsfrom 30 to 100 (with 100ms interval, extending timeout from 3s to 10s)
Collaborator
|
I am wary about this. we have code now that tries to find a crash, but if that fails then users will just stare at a blank screen for 10 seconds before seeing an error. they might not and never tell us what's wrong can we make this dependent on whether the app is packaged? |
Collaborator
Author
|
@DOsinga I thought about that, but what about when you install a new version of goose? Doesn't macos check the notarization in that case too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine, the macos notarization check often takes ~3.5 seconds.