scan recipe for security when saving recipe #5747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds security validation to the save_recipe endpoint to detect and block recipes containing invisible Unicode tag characters (U+E0000-U+E007F) that could be used for steganographic attacks. The validation rejects such recipes before they are saved to disk.
- Adds a security check using
check_for_security_warnings()before saving recipes - Returns a clear error message when malicious Unicode tag characters are detected
Comments suppressed due to low confidence (1)
crates/goose-server/src/routes/recipe.rs:339
- The OpenAPI documentation specifies status 204 (No Content) for success, but the endpoint actually returns status 200 with a JSON body (SaveRecipeResponse). Either update the documentation to status 200 or change the implementation to return 204 with no body.
(status = 204, description = "Recipe saved to file successfully", body = SaveRecipeResponse),
DOsinga
approved these changes
Nov 14, 2025
| let has_security_warnings = request.recipe.check_for_security_warnings(); | ||
| if has_security_warnings { | ||
| return Err(ErrorResponse { | ||
| message: "This recipe contains hidden characters that will be ignored for your safety, as they could be used for malicious purposes.".to_string(), |
Collaborator
There was a problem hiding this comment.
isn't it more the case that we are refusing the save this recipe? so say something like, this contains hidden characters, please remove before trying to save?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Scan recipe for security when saving recipe
Type of Change
Testing
Manual testing