Skip to content

Conversation

@chetanyb
Copy link
Contributor

Fixes compilation errors discovered during ssz.zig integration:

  • Remove invalid message parameter from assert() call (std.debug.assert only accepts boolean)
  • Fix type mismatch in compress feed-forward: convert input to Montgomery form before addition
  • Replace non-existent fromMontgomery() with toNormal() method
  • Return proper array type instead of slice

@chetanyb chetanyb requested review from ch4r10t33r and jsign and removed request for ch4r10t33r October 18, 2025 18:20
Copy link
Contributor

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Should we also include a test for this? I am surprised this compilation error wasn't caught before. Also please can you bump the version?

@chetanyb
Copy link
Contributor Author

This looks good. Should we also include a test for this? I am surprised this compilation error wasn't caught before. Also please can you bump the version?

should we add tests to this PR itself or should I make a separate one for that?
Let's update the version post the tests? So the next release would also have substantial changes including your field ones.

@ch4r10t33r
Copy link
Contributor

This looks good. Should we also include a test for this? I am surprised this compilation error wasn't caught before. Also please can you bump the version?

should we add tests to this PR itself or should I make a separate one for that? Let's update the version post the tests? So the next release would also have substantial changes including your field ones.

I would prefer you adding tests to this PR itself. But yes, I agree we can release a new version once you are satisfied after testing.

@chetanyb
Copy link
Contributor Author

@ch4r10t33r can we get this merged first? Will raise the test PR separately. This way we all have these changes and I can even get the ssz integration PR out

@ch4r10t33r
Copy link
Contributor

Sounds good to me.

@chetanyb chetanyb merged commit c2281f8 into blockblaz:main Oct 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants