Skip to content

Update python 3.8 version in CI/CD #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

kome12
Copy link
Collaborator

@kome12 kome12 commented Oct 16, 2024

What?

Updating the python version in the CI/CD because it was failing. An example of a failing check is here.

How?

Updated python version to latest in 3.8

Related PRs (optional)

PRs that are related to this or may need to be deployed before this PR

Anything Else?

@kome12 kome12 self-assigned this Oct 16, 2024
@kome12 kome12 changed the title Test using higher version of 3.8 Update python 3.8 version in CI/CD Oct 16, 2024
@araa47 araa47 merged commit 3993ee8 into blockchain-etl:master Oct 16, 2024
3 checks passed
@kome12 kome12 deleted the fix/update-python-version branch October 16, 2024 01:22
@charlielewisme
Copy link
Collaborator

charlielewisme commented Oct 16, 2024

@kome12
Thanks for the fix.

I just want to add a note about the reason for specifying 3.8.12 -- it exactly matches the Python version used in composer-2.1.14-airflow-2.5.1 which is the version we use in our current production environment ethereum-etl-prod-5. See Cloud Composer version list in GCP docs.

For now the mismatch in versions between CI/CD and production is really nothing to worry about. But depending on our productivity bandwidth we should consider upgrading to a newer version of Composer. Note: please do NOT do this by clicking the "upgrade" button in the UI (too unstable) -- we need first to check and test dependencies etc. It's not a big task but must be done with care.

@kome12
Copy link
Collaborator Author

kome12 commented Oct 16, 2024

@kome12 Thanks for the fix.

I just want to add a note about the reason for specifying 3.8.12 -- it exactly matches the Python version used in composer-2.1.14-airflow-2.5.1 which is the version we use in our current production environment ethereum-etl-prod-5. See Cloud Composer version list in GCP docs.

For now the mismatch in versions between CI/CD and production is really nothing to worry about. But depending on our productivity bandwidth we should consider upgrading to a newer version of Composer. Note: please do NOT do this by clicking the "upgrade" button in the UI (too unstable) -- we need first to check and test dependencies etc. It's not a big task but must be done with care.

Ah, got it! I didn't realize that, should have double checked with you before merging.

I won't touch the composer side for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants