WIP #1008
Open
WIP #1008
+722
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorjesinpo
force-pushed
the
dev/optimize-subscriptions
branch
6 times, most recently
from
6f33a89 to
2116b6a
Compare
678098
reviewed
Nov 5, 2025
| }; | ||
|
|
||
| typedef bsl::map<int, Priority, std::greater<int> > Priorities; | ||
| typedef Learning<unsigned int> Learning; |
Collaborator
There was a problem hiding this comment.
Note that this code introduces lots of warnings from any sources including mqbblp_routers.h
/blazingmq/src/groups/mqb/mqbblp/mqbblp_routers.h:843:36: warning: declaration of ‘typedef class BloombergLP::mqbblp::Learning<unsigned int> BloombergLP::mqbblp::Routers::Learning’ changes meaning of ‘Learning’ [-Wchanges-meaning]
843 | typedef Learning<unsigned int> Learning;
| ^~~~~~~~
/blazingmq/src/groups/mqb/mqbblp/mqbblp_routers.h:843:13: note: used here to mean ‘class BloombergLP::mqbblp::Learning<unsigned int>’
843 | typedef Learning<unsigned int> Learning;
| ^~~~~~~~~~~~~~~~~~~~~~
/blazingmq/src/groups/mqb/mqbblp/mqbblp_routers.h:224:7: note: declared here
224 | class Learning {
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
dorjesinpo
force-pushed
the
dev/optimize-subscriptions
branch
from
2116b6a to
b20ad4a
Compare
Signed-off-by: dorjesinpo <[email protected]>
dorjesinpo
force-pushed
the
dev/optimize-subscriptions
branch
from
b20ad4a to
0f3f999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP