Cleanup[bmqt::Uri]: add deprecation note for initialize/shutdown #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
commented
Nov 13, 2025
| { | ||
| bdlma::LocalSequentialAllocator<1024> localAllocator( | ||
| bslma::Default::allocator()); | ||
| bdlma::LocalSequentialAllocator<1024> localAllocator; |
Collaborator
Author
There was a problem hiding this comment.
It uses the default allocator by default if no allocator provided
678098
commented
Nov 13, 2025
|
|
||
| // Shut down the parser is a no-op. | ||
| bmqt::UriParser::shutdown(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
initialize/shutdown are simply no-op, not worth having any tests for it anymore
678098
force-pushed
the
251113_bmqtUri_cleanup
branch
from
216ae7a to
c1be850
Compare
678098
changed the title
678098
force-pushed
the
251113_bmqtUri_cleanup
branch
4 times, most recently
from
cf26d48 to
fa6d1fb
Compare
…wn; remove its usage Signed-off-by: Evgeny Malygin <[email protected]>
678098
force-pushed
the
251113_bmqtUri_cleanup
branch
from
fa6d1fb to
226628b
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
678098
commented
Nov 14, 2025
| /// called. | ||
| static void shutdown(); | ||
| /// DEPRECATED: Not needed anymore (no-op). This method will be marked | ||
| /// as `BSLA_DEPRECATED` in future release of libbmq. |
Collaborator
Author
There was a problem hiding this comment.
I've seen this pattern in other files.
For some reason, we don't add annotation BSLA_DEPRECATED right away and put a comment before this. Maybe it is done for someone who has warnings are errors setting
678098
commented
Nov 14, 2025
| bsls::TimeUtil::initialize(); | ||
|
|
||
| // Prepare the UriParser regexp | ||
| bmqt::UriParser::initialize(); |
Collaborator
Author
There was a problem hiding this comment.
Note that there was no shutdown in bmqtool.
Also, there were no initialize/shutdown in our tutorial clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bmqt::Uridocsbmqt_uri.h/bmqt_uri.cppbmqt::UriParse::initialize/bmqt::UriParse::shutdownbmqt::UriParse::initialize/bmqt::UriParse::shutdownusage from the codebasebmqt::UriRegEx usage