Cleanup mqbconfm #856
Draft
Cleanup mqbconfm #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pniedzielski
force-pushed
the
cleanup/mqbconf
branch
3 times, most recently
from
f87c208 to
d2a8a34
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
pniedzielski
force-pushed
the
cleanup/mqbconf
branch
2 times, most recently
from
7d639e6 to
763cfeb
Compare
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
cleanup/mqbconf
branch
2 times, most recently
from
4002be6 to
ac5dac9
Compare
This patch prepares the failure path of `mqba_configprovider` to not use `Response` from mqbconfm. It refactors the return path and adds a new `enum` with proper return codes. Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
…cted This shows that the log was incorrect. Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
cleanup/mqbconf
branch
2 times, most recently
from
2933192 to
00e9611
Compare
The `mqba::DomainResolver::executeScript` function declaration has no implementation, and is otherwise unused. It was a legacy from before static domain configuration. This patch removes this declaration, which also removes one reference to `mqbconfm::DomainResolver`. Signed-off-by: Patrick M. Niedzielski <[email protected]>
The `mqbconfm::DomainResolver` generated type is a pair of two strings: the resolved domain name and the cluster name. This type is a legacy from before our current, static domain configuration format. Rather than keeping this type in `mqbconf.xsd`, which otherwise describes the static domain configuration format, we can just pass two strings around. This patch makes that refactor. Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
cleanup/mqbconf
branch
from
00e9611 to
e9ca82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some legacy types in
mqbconfmthat don't directly relate to domain configuration, such asRequestandResponsetypes.The
Requesttype can be removed with no issue.The
ResponseandDomainResolvertypes are used internally inmqba::ConfigProviderandmqba::DomainResolver, and can be replaced with simplebsl::strings.TODO
ConfigProviderDomainResolver