FIX[MQB]: cancelRead might cause a deadlock
#948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emelialei88
changed the title
emelialei88
force-pushed
the
fix/remove-cancel-read
branch
from
280036a to
129c5e0
Compare
emelialei88
changed the title
cancelRead might cause a deadlock
Signed-off-by: Emelia Lei <[email protected]>
emelialei88
force-pushed
the
fix/remove-cancel-read
branch
from
129c5e0 to
7df1110
Compare
bbpetukhov
pushed a commit
to bbpetukhov/blazingmq
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Emelia Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed a deadlock during a fuzz test (Fuzz test [identity]) that's hard to reproduce. Before the test hangs, we saw "tearDown" being printed but not "tearDownImpl", so the assumption for the deadlock falls under
cancelReadfunction. Since read is cancelled inNTCduring channel close anyways, we decide to remove thecancelReadfor ourClientSessionandAdminSession.