Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helm chart #137

Merged
merged 8 commits into from
May 14, 2024
Merged

feat: add helm chart #137

merged 8 commits into from
May 14, 2024

Conversation

DerekTBrown
Copy link
Contributor

@DerekTBrown DerekTBrown commented Sep 25, 2023

What does this PR do?

  1. Adds an official Helm chart for Goldpinger, copied from the one published by @okgolove (https://github.com/okgolove/helm-charts/tree/master/charts/goldpinger); also licensed under Apache 2.0.
  2. Adds a GitHub Action to publish the Goldpinger chart to GH Pages (will require the GitHub admin to enable some things before this will fully work).
  3. Adds a Tiltfile for launching Goldpinger via the Helm chart.
  4. Adds a script (called by the Tiltfile) that validates that Goldpinger works as expected on a two-node cluster.
  5. Updated the documentation accordingly.

Why do we need this?

  1. This will improve the experience of installing Goldpinger for users, since they can install the daemonset with a few commands.
  2. This will make it easier to evolve Goldpinger in the future, as there is a shared/default understanding of how it is deployed.

How is this PR tested?

I was able to validate the end-to-end behavior using act:

act -j helm_test --container-architecture linux/amd64 pull_request
...
<success>

I will need someone's assistance testing the release behavior using GitHub Actions, since this is dependent on access to the repo itself.

@DerekTBrown DerekTBrown marked this pull request as ready for review September 25, 2023 22:48
Copy link
Contributor

@skamboj skamboj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing this Helm chart. Apologies it took so long for us to approve it and merge it in. We will setup the publishing of the helm chart.

LGTM, :shipit:

@skamboj skamboj merged commit 36b0aed into bloomberg:master May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants