Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docs on every PR, not just releases #602

Merged
merged 1 commit into from
May 20, 2024

Conversation

godlygeek
Copy link
Contributor

I don't want to merge this PR, but letting CI run it will allow updated docs to be published.

@godlygeek godlygeek self-assigned this May 20, 2024
@godlygeek
Copy link
Contributor Author

Oops, this doesn't work the way I hoped it would - we don't have the token to publish the docs from a PR, so this would need to be merged in order to work...

@godlygeek godlygeek marked this pull request as ready for review May 20, 2024 14:30
We can revert this later, but it will be helpful to us during the PyCon
US 2024 sprints.

Signed-off-by: Matt Wozniski <[email protected]>
Copy link
Contributor

@sarahmonod sarahmonod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

publish_docs:
name: Publish docs
runs-on: ubuntu-latest
#if: github.event_name == 'release' && github.event.action == 'published'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether we would want this to be like this forever, but at least while sprinting in PyCon this is super useful.

@sarahmonod sarahmonod enabled auto-merge (rebase) May 20, 2024 14:42
@sarahmonod sarahmonod merged commit a82e412 into bloomberg:main May 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants