Merged
Conversation
godlygeek
force-pushed
the
support_new_textual_footer
branch
from
83488fa to
386b2de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 92.55% 92.86% +0.31%
==========================================
Files 91 92 +1
Lines 11304 11237 -67
Branches 1581 2055 +474
==========================================
- Hits 10462 10435 -27
+ Misses 837 802 -35
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We need to update the Textual footer whenever we change a key binding. Textual 0.63 breaks the approach that we have been using up until now. Switch to a new approach that works with newer versions of Textual. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
The updated Footer tries to get the active bindings when it is mounted. Since our bindings rewriting accesses the `paused` and `disconnected` reactives, that caused those reactives to be initialized earlier than normal, which caused their watchers to fire earlier than normal. One of those watchers tries to query a widget which hasn't yet been mounted, and fails. Work around this by setting those two reactives up to not call their watchers when they're first initialized. We may want to apply that to other reactives as well, but for now I'm scoping this to the smallest possible change that fixes the issue. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
The new footer has a different style. Update our snapshot tests to expect it. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
support_new_textual_footer
branch
from
386b2de to
e2163c3
Compare
pablogsal
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Textual 0.63 introduced a new Footer widget. We need some changes to work with this: