[WIP] Add unit tests #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawalt
force-pushed
the
pawalt/add-unit-tests
branch
from
9be144c
to
a51b330
Compare
dennisgove
reviewed
Jan 3, 2020
pawalt
force-pushed
the
pawalt/add-unit-tests
branch
2 times, most recently
from
cd9852b
to
0355290
Compare
twexler
reviewed
Jan 8, 2020
pawalt
force-pushed
the
pawalt/add-unit-tests
branch
from
0355290
to
6e605c6
Compare
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
twexler
reviewed
Jan 9, 2020
internal/common/spiretrustsource.go
Outdated
| if strings.Contains(domain, "/") { | ||
| return fmt.Errorf("expected domain without slash but got %s", domain) | ||
| } | ||
| certPath := s.certLocation + "/" + domain + ".pem" |
There was a problem hiding this comment.
What from filepath would be useful?
pawalt
force-pushed
the
pawalt/add-unit-tests
branch
from
6e605c6
to
de6ef85
Compare
added 7 commits
January 15, 2020 11:45
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
added 2 commits
January 15, 2020 17:18
Signed-off-by: Peyton Walters <[email protected]>
Signed-off-by: Peyton Walters <[email protected]>
pawalt
force-pushed
the
pawalt/add-unit-tests
branch
from
f7c1713
to
1ceae6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #4
Describe your changes
This PR adds unit tests to common and fixes warnings brought up by
go-lintTesting performed
This is it
Additional context
This PR has a lot of small changes to variable naming and such. While we could keep our old names, I'd like to conform to
go-lintas much as possible.Also, this needs to wait until #14 is merged