-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(op-precompiles): Check subset of l1 precompiles in op #2204
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #2204 will degrade performances by 2.07%Comparing Summary
Benchmarks breakdown
|
ae1af23
to
528a1bf
Compare
@rakita could you pls explain how tests pass locally without default features, but not in ci? |
Need to check to be sure, but bls does not have a no_std variant so one precompile will be missing. |
Lets wait for #2210, it should make that test pass. blst are not supported for no_std but for kona they accelare all precompiles so they are fine without it. |
#2249 is done so if we merge this, diff would be same. if there is no bls feature and this precompile is called by default it will throw Fatal error. |
found the issue here, when blst is not enabled, we still add all the addresses to Prague with |
odd , this still works locally, but in ci the output is different |
ah it's the precompile function pointers that are different in ci for Prague and isthmus sets...no easy way around that unfortunately. equality of function pointers is needed to see that granite overwrites the bn128 pair. will simplify the difference check to just check for address, to make it pass in ci. that granite overwrites bn128 pair is checked in another test already. |
Ref #2189
Checks that subset of l1 precompiles are part of op precompiles wrt hardfork