Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: special case G1 and G2 scalar multiplication #2248

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

kevaundray
Copy link
Contributor

When an G1_MSM or G2_MSM is called with a single input, we can us the simpler scalar multiplication algorithm instead of the MSM algorithm.

@kevaundray
Copy link
Contributor Author

Same comment as here: #2247 (comment)

@kevaundray kevaundray marked this pull request as ready for review March 18, 2025 21:11
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #2248 will not alter performance

Comparing kevaundray:kw/special-case-msm-size-1 (a91cd70) with main (e99a186)

Summary

✅ 8 untouched benchmarks

@rakita
Copy link
Member

rakita commented Mar 19, 2025

Part of the test that runs statetest is passing, EOF validation that is failing is fixed on main

@rakita rakita merged commit f2c3db1 into bluealloy:main Mar 19, 2025
25 of 33 checks passed
This was referenced Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants