chore: sort storage keys and test files in blockchaintest output #3186
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3186 will not alter performanceComparing Summary
|
rakita
reviewed
Nov 21, 2025
| .map(DirEntry::into_path) | ||
| .collect() | ||
| .collect(); | ||
| files.sort(); |
Member
There was a problem hiding this comment.
It is better for file names to be in order of reading
rakita
reviewed
Nov 21, 2025
| for (key, value) in storage.iter().take(5) { | ||
| let mut sorted_storage: Vec<_> = storage.iter().collect(); | ||
| sorted_storage.sort_by_key(|(key, _)| *key); | ||
| for (key, value) in sorted_storage.iter().take(5) { |
Member
There was a problem hiding this comment.
This is nice, i would even remove that 5 slot limit and print all of them
rakita
reviewed
Nov 21, 2025
| for (key, value) in storage.iter().take(5) { | ||
| let mut sorted_storage: Vec<_> = storage.iter().collect(); | ||
| sorted_storage.sort_by_key(|(key, _)| *key); | ||
| for (key, value) in sorted_storage.iter().take(5) { |
Member
There was a problem hiding this comment.
Makes sense, would remove 5 limit, for tests we want to read them all
rakita
reviewed
Nov 21, 2025
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
Makes sense, left few nit comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized there are more section need to be optimize like #3182
Any though?