core: services: beacon: fix broken ethernet domain name config

bluerobotics · Apr 17, 2024 · b483caf · b483caf
1 parent 9fe2a19
commit b483caf
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/core/services/beacon/main.py b/core/services/beacon/main.py
@@ -113,7 +113,13 @@ def set_hostname(self, hostname: str) -> None:
         for interface in self.manager.settings.interfaces:
             match InterfaceType.guess_from_name(interface.name):
                 case InterfaceType.WIRED | InterfaceType.USB:
-                    interface.domain_names = [hostname, self.DEFAULT_HOSTNAME]  # let's keep our default just in case
+                    interface.domain_names = [
+                        old_name.replace(self.DEFAULT_HOSTNAME, hostname)
+                        for old_name in interface.domain_names
+                    ]
+                    # Let's keep our default just in case
+                    if self.DEFAULT_HOSTNAME not in interface.domain_names:
+                        interface.domain_names.append(self.DEFAULT_HOSTNAME)
                 case InterfaceType.WIFI:
                     interface.domain_names = [f"{hostname}-wifi"]
                 case InterfaceType.HOTSPOT: