-
Notifications
You must be signed in to change notification settings - Fork 100
core:services:versionchooser: Fix yarl & python-multipart #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core:services:versionchooser: Fix yarl & python-multipart #3412
Conversation
* Fix yarl version to avoid error when aiohttp is parsing URLs
Reviewer's GuideThis PR explicitly locks the versions of python-multipart and yarl in their respective service pyproject.toml files—adding comments to explain the pins—and regenerates the uv.lock file to include these constraints. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joaomariolago - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
7163161
to
a671d9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joaomariolago - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `core/services/versionchooser/pyproject.toml:14` </location>
<code_context>
"connexion[aiohttp,swagger-ui]==2.14.2",
"docker==6.0.0",
"loguru==0.5.3",
+ # This dependency needs to be locked due to error in aiohttp
+ "yarl==1.12.1",
]
</code_context>
<issue_to_address>
Consider specifying the nature of the aiohttp error requiring yarl pinning.
Adding details or a reference about the specific aiohttp error and affected versions will clarify the reason for pinning yarl and assist future maintenance.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
# This dependency needs to be locked due to error in aiohttp
"yarl==1.12.1",
=======
# Pin yarl due to incompatibility with aiohttp 3.x and yarl>=1.13.0, which causes import errors.
# See: https://github.com/aio-libs/aiohttp/issues/4324
"yarl==1.12.1",
>>>>>>> REPLACE
</suggested_fix>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# This dependency needs to be locked due to error in aiohttp | ||
"yarl==1.12.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider specifying the nature of the aiohttp error requiring yarl pinning.
Adding details or a reference about the specific aiohttp error and affected versions will clarify the reason for pinning yarl and assist future maintenance.
# This dependency needs to be locked due to error in aiohttp | |
"yarl==1.12.1", | |
# Pin yarl due to incompatibility with aiohttp 3.x and yarl>=1.13.0, which causes import errors. | |
# See: https://github.com/aio-libs/aiohttp/issues/4324 | |
"yarl==1.12.1", |
Fix a small mess that #3396 pushed to master...
And make sure it is explicit that they are locked because other libraries couldn't lock by them self....
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Lock yarl and python-multipart to fixed versions in relevant services and update the lock file to prevent URL parsing and multipart form errors in aiohttp and FastAPI.
Bug Fixes:
Enhancements:
Build: